| Author |
Message |
M. Warner Losh
*nix forums Guru
Joined: 22 Mar 2002
Posts: 365
|
 Posted: Fri May 03, 2002 3:37 am Post subject:
Re: Removal of register && K&R function decl.
|
|
|
In message: <20020502141150.B40128@dragon.nuxi.com>
"David O'Brien" <obrien@FreeBSD.ORG> writes:
: > as well as ansification of functions?
:
: You are free to do so -- BUT PLEASE do it by committing the ANSIfication
: and ONLY THE ANSIfication in a separate commit from anything else.
While I started out not doing this, David convinced me this was a good
idea and should be strived for in non-silly cases.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
 |
David O'Brien
*nix forums beginner
Joined: 02 May 2002
Posts: 1
|
| Posted: Thu May 02, 2002 7:11 pm Post subject:
Re: Removal of register && K&R function decl.
|
|
|
On Wed, May 01, 2002 at 07:39:37PM -0400, Jeff Roberson wrote:
| Quote: | What is the policy on commits soley to remove the register keyword,
|
I purposefully have not touched 'register' in the kernel as some felt it
still had a use there. Do we want it removed?
| Quote: | as well as ansification of functions?
|
You are free to do so -- BUT PLEASE do it by committing the ANSIfication
and ONLY THE ANSIfication in a separate commit from anything else.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Alexey Dokuchaev
*nix forums beginner
Joined: 02 May 2002
Posts: 42
|
| Posted: Thu May 02, 2002 10:58 am Post subject:
Re: Removal of register && K&R function decl.
|
|
|
On Wed, May 01, 2002 at 05:45:26PM -0700, Alfred Perlstein wrote:
| Quote: | * Dag-Erling Smorgrav <des@ofug.org> [020501 17:35] wrote:
Alfred Perlstein <bright@mu.org> writes:
Please don't ansify functions, some people prefer the old style.
Last time this came up, the consensus was that ANSIfication was
permitted.
We also have KSE and SMPng work to do. Also ANSIfication makes the
code look terrible when there's more than 3 arguments.
|
Not to mention, this "old style" (K&R) gives code that special *BSD look
we all love ;-)
../danfe
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Terry Lambert
*nix forums Guru
Joined: 19 Mar 2002
Posts: 434
|
| Posted: Thu May 02, 2002 5:02 am Post subject:
Re: Removal of register && K&R function decl.
|
|
|
Alfred Perlstein wrote:
| Quote: | We also have KSE and SMPng work to do. Also ANSIfication makes the
code look terrible when there's more than 3 arguments.
|
Note(The, Normal, Thing, To, Do, In, That, Case)
Note(Is,
To,
Declare,
Things,
This,
Way)
....thus making the ANSI declarations look more like K&R declarations.
8-)  .
-- Terry
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Terry Lambert
*nix forums Guru
Joined: 19 Mar 2002
Posts: 434
|
| Posted: Thu May 02, 2002 5:00 am Post subject:
Re: Removal of register && K&R function decl.
|
|
|
Dag-Erling Smorgrav wrote:
| Quote: | Alfred Perlstein <bright@mu.org> writes:
Please don't ansify functions, some people prefer the old style.
Last time this came up, the consensus was that ANSIfication was
permitted.
|
I thought that the consensus was to "vote with NetBSD and OpenBSD"
on a case-by-case basis to reduce the gratuitous diffs?
I know the consensus was to get rid of __P, so that header declarations
were prototypes. But that doesn't really translate to changing
all the code everywhere to use prototypes in actual function
declarations.
If NetBSD and OpenBSD have changed it, then as long as the changes
are whitespace equal to them, I personally would have no problem
with it; K&R compilation was already broken when __P() was ripped
out.
-- Terry
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Garance A Drosihn
*nix forums Guru Wannabe
Joined: 21 Mar 2002
Posts: 190
|
| Posted: Wed May 01, 2002 11:39 pm Post subject:
Re: Removal of register && K&R function decl.
|
|
|
At 7:39 PM -0400 5/1/02, Jeff Roberson wrote:
| Quote: | What is the policy on commits soley to remove the register
keyword, as well as ansification of functions?
|
The decision has already been made that ansi-fication of source
is a good idea, and many commits have been made along those lines
in the last few months. I'm pretty sure the consensus is that
it's also a good idea to remove 'register' references, generally
done as a separate commit. That way it's a little easier to test
that no bugs are introduced by the ansi-fication.
| Quote: | A certain eager contributor would like to do a general sweep
through kern/* to remove these antiquities.
|
However, with all the SMPng and other kernel work going on, it
probably would not be a good idea to go running around changing
those particular source files. Ansi-fication is a "good thing",
but it is not a high-priority change to make. It is not a
"good thing" if doing this will disrupt other work which is
actively going on in the same source files. You'd need to
check on a file-by-file basis to see if anyone's working on
it, instead of trying for a general sweep through all the files.
Note that I don't work on the kern files, so the above is just
my own opinion.
--
Garance Alistair Drosehn = gad@gilead.netel.rpi.edu
Senior Systems Programmer or gad@freebsd.org
Rensselaer Polytechnic Institute or drosih@rpi.edu
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Alfred Perlstein
*nix forums addict
Joined: 19 Mar 2002
Posts: 67
|
| Posted: Wed May 01, 2002 11:39 pm Post subject:
Re: Removal of register && K&R function decl.
|
|
|
* Dag-Erling Smorgrav <des@ofug.org> [020501 17:35] wrote:
| Quote: | Alfred Perlstein <bright@mu.org> writes:
Please don't ansify functions, some people prefer the old style.
Last time this came up, the consensus was that ANSIfication was
permitted.
|
We also have KSE and SMPng work to do. Also ANSIfication makes the
code look terrible when there's more than 3 arguments.
--
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'
Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Dag-Erling Smorgrav
*nix forums Guru Wannabe
Joined: 23 Mar 2002
Posts: 110
|
| Posted: Wed May 01, 2002 11:39 pm Post subject:
Re: Removal of register && K&R function decl.
|
|
|
Alfred Perlstein <bright@mu.org> writes:
| Quote: | Please don't ansify functions, some people prefer the old style.
|
Last time this came up, the consensus was that ANSIfication was
permitted.
DES
--
Dag-Erling Smorgrav - des@ofug.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Alfred Perlstein
*nix forums addict
Joined: 19 Mar 2002
Posts: 67
|
| Posted: Wed May 01, 2002 11:39 pm Post subject:
Re: Removal of register && K&R function decl.
|
|
|
* Jeff Roberson <jeff@freebsd.org> [020501 16:39] wrote:
| Quote: | What is the policy on commits soley to remove the register keyword, as
well as ansification of functions? A certain eager contributor would like
to do a general sweep through kern/* to remove these antiquities. Would
this create too many diffs for people actively devloping in these areas?
If not I agreed to review and commit these patches as they come.
|
Please only remove 'register' when doing cleanups of your own code.
Please don't ansify functions, some people prefer the old style.
--
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'
Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Jeff Roberson
*nix forums Guru Wannabe
Joined: 08 Apr 2002
Posts: 107
|
| Posted: Wed May 01, 2002 11:39 pm Post subject:
Removal of register && K&R function decl.
|
|
|
What is the policy on commits soley to remove the register keyword, as
well as ansification of functions? A certain eager contributor would like
to do a general sweep through kern/* to remove these antiquities. Would
this create too many diffs for people actively devloping in these areas?
If not I agreed to review and commit these patches as they come.
Thanks,
Jeff
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message |
|
| Back to top |
|
|
Google
|
|
| Back to top |
|
|
|
FAQ
Search
Memberlist
Usergroups
Register
Profile
Log in to check your private messages
Log in
Forum index
»
*nix
»
BSD
»
FreeBSD
»
mail-lists
»
Architecture
