|
|
|
|
|
|
| Author |
Message |
gnn@freebsd.org
*nix forums beginner
Joined: 11 Aug 2005
Posts: 15
|
 Posted: Wed Jun 28, 2006 4:34 am Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
At Tue, 27 Jun 2006 13:58:17 -0600 (MDT),
M. Warner Losh wrote:
Works for me. Commit it :-)
Later,
George
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
 |
Yar Tikhiy
*nix forums beginner
Joined: 08 Apr 2003
Posts: 36
|
| Posted: Wed Jun 28, 2006 9:42 am Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
On Tue, Jun 27, 2006 at 01:58:17PM -0600, M. Warner Losh wrote:
| Quote: | NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
is defined). I'd like to do something similar in FreeBSD. I see no
reason to needless deviate from NetBSD here. One could make an
argument for lots of different files, but at the end of the day does
it really matter enough to justify having it be different than NetBSD?
Here's my proposed diff, inline, for your consideration:
Index: types.h
===================================================================
RCS file: /home/ncvs/src/sys/sys/types.h,v
retrieving revision 1.95
diff -u -r1.95 types.h
--- types.h 26 Nov 2005 12:42:35 -0000 1.95
+++ types.h 27 Jun 2006 19:57:23 -0000
@@ -294,6 +294,11 @@
#define offsetof(type, field) __offsetof(type, field)
+/* Macros to clear/set/test flags. */
+#define SET(t, f) (t) |= (f)
+#define CLR(t, f) (t) &= ~(f)
+#define ISSET(t, f) ((t) & (f))
+
#endif /* !_KERNEL */
/*
NOTE: That /* !_KERNEL */ should have the '!' removed, but I didn't
want to confuse things by doing that too.
Comments?
|
I'd rather enclose the whole RHS of SET and CLR in parentheses.
It's still C; SET and CLR can be used in expressions and cause
precedence artefacts if not parenthesised.
--
Yar
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Poul-Henning Kamp
*nix forums Guru
Joined: 21 Mar 2002
Posts: 436
|
| Posted: Wed Jun 28, 2006 9:53 am Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
In message <20060628094221.GA50978@comp.chem.msu.su>, Yar Tikhiy writes:
| Quote: | On Tue, Jun 27, 2006 at 01:58:17PM -0600, M. Warner Losh wrote:
NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
is defined).
|
As one of the people who have worked with the original /bin/sh source
code, I have a slight alergic reaction to attempts to paste over
the implementation language with macros like these.
Setting a bit in 'C' is spelled
variable |= bit;
not
SET(variable, bit);
Higher order macros like roundup(), ispow2() are fine with me,
because they implement something on top of the language and make
the source code more compact and thus faster to read.
But all of the three proposed macros take up more space than
the native language they obfuscate, what is the sense in that ?
If we want to have them for NETBSD compatibility, they should
be enclosed in
#ifdef NETBSD_COMPAT
#endif
Or better yet: be put in sys/sys/netbsd_compat.h
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Andrew Reilly
*nix forums Guru Wannabe
Joined: 26 Apr 2002
Posts: 148
|
| Posted: Wed Jun 28, 2006 10:08 am Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
On Wed, Jun 28, 2006 at 09:53:46AM +0000, Poul-Henning Kamp wrote:
| Quote: | In message <20060628094221.GA50978@comp.chem.msu.su>, Yar Tikhiy writes:
On Tue, Jun 27, 2006 at 01:58:17PM -0600, M. Warner Losh wrote:
NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
is defined).
As one of the people who have worked with the original /bin/sh source
code, I have a slight alergic reaction to attempts to paste over
the implementation language with macros like these.
Setting a bit in 'C' is spelled
variable |= bit;
not
SET(variable, bit);
|
To my eye, if you're going to use "bit" to describe which bit is
being operated on, then you should *really* be doing:
variable |= (1 << bit)
and, obviously, SET(variable, bit) should do that, rather than
what has been proposed.
What you're spelling, above, and what the NetBSD macros that
Warner described do are actually doing:
SET(variable, mask).
Compatability is a good thing, and if it's convenient to have
NetBSD compatability macros, then go do it, but I think that
it's important that they advertise what they're doing correctly.
(Like the colour now?)
Cheers,
--
Andrew
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Alex Lyashkov
*nix forums beginner
Joined: 06 Jun 2006
Posts: 10
|
| Posted: Wed Jun 28, 2006 10:21 am Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
÷ ÷ÔÒ, 27.06.2006, × 22:58, M. Warner Losh ÐÉÛÅÔ:
| Quote: | NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
is defined). I'd like to do something similar in FreeBSD. I see no
reason to needless deviate from NetBSD here. One could make an
argument for lots of different files, but at the end of the day does
it really matter enough to justify having it be different than NetBSD?
Here's my proposed diff, inline, for your consideration:
NOTE: That /* !_KERNEL */ should have the '!' removed, but I didn't
want to confuse things by doing that too.
Comments?
Warner
_______________________________________________
Who not create abstract framework for work with bitmask more then 64bits |
size?
similar this:
#define_bitmask(name,size) char name[(size/ +1];
#define set_bit(bimask,no) { bitmask[(no/] |= 1<<(no%; }
#define clr_bit(bitmask,no) { bitmask[(no/] &= ~(1<<(no%); }
static inline isset_bit(char *bitmask, no) {
return bitmask[(no/] & 1<<(no%;
}
--
Alex Lyashkov <shadow@psoft.net>
Positive Software
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Bruce Evans
*nix forums Guru Wannabe
Joined: 22 Mar 2002
Posts: 190
|
| Posted: Wed Jun 28, 2006 12:55 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
On Wed, 28 Jun 2006, Poul-Henning Kamp wrote:
| Quote: | In message <20060628094221.GA50978@comp.chem.msu.su>, Yar Tikhiy writes:
On Tue, Jun 27, 2006 at 01:58:17PM -0600, M. Warner Losh wrote:
NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
is defined).
|
I see no types here.
| Quote: | As one of the people who have worked with the original /bin/sh source
code, I have a slight alergic reaction to attempts to paste over
the implementation language with macros like these.
Setting a bit in 'C' is spelled
variable |= bit;
not
SET(variable, bit);
|
Only slightly?
In FreeBSD, these mistakes were only in kern/tty.c and in some usb
files obtained from NetBSD and related to tty.c. In tty.c, they appear
to be just to avoid adding a USL copyright. (tty.c was obfuscated
between FreeBSD-1 and FreeBSD-2 by globally substituting "variable |=
BIT" by "SET(variable, BIT)", etc.) I noticed that NetBSD started
using these macros elsewhere many years ago. However, their use was
still relatively limited in NetBSD a year ago (in kern, they were only
in kern-fork.c (1), kern_subr.c (2), kern_systrace.c (many), sys_process.c
(a few), tty.c (many), tty_pty.c (many), vfs_bio.c (many) and vfs_lookup.c
(1); 211 lines altogether vs 1565 lines matching ' & ' and 27 lines
matching the style bug '[A-Za-z]&[A-Za-z]'). It must have been in
tty_pty.c that I noticed them many years ago.
| Quote: | Higher order macros like roundup(), ispow2() are fine with me,
because they implement something on top of the language and make
the source code more compact and thus faster to read.
But all of the three proposed macros take up more space than
the native language they obfuscate, what is the sense in that ?
|
They might be to hide the implementation of a set of flags as a bitmap,
but they don't even do that.
Another problem with these macros is that a bitmap is more useful than
a set of flags, but a much larger and uglier set of macros would be
needed to give enough operations on bitmaps, and code that has been
blindly translated from an integer-bitmap operation still assumes that
the implementation is an integer-bitmap. E.g., in tty.c:
%%%
/*
* delayed suspend (^Y)
*/
if (CCEQ(cc[VDSUSP], c) &&
ISSET(lflag, IEXTEN | ISIG) == (IEXTEN | ISIG)) {
%%%
Bruce
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Alex Lyashkov
*nix forums beginner
Joined: 06 Jun 2006
Posts: 10
|
| Posted: Wed Jun 28, 2006 1:26 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
÷ óÒÄ, 28.06.2006, × 14:39, Harti Brandt ÐÉÛÅÔ:
| Quote: | On Wed, 28 Jun 2006, Alex Lyashkov wrote:
AL>÷ ÷ÔÒ, 27.06.2006, × 22:58, M. Warner Losh ÐÉÛÅÔ:
AL>> NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
AL>> is defined). I'd like to do something similar in FreeBSD. I see no
AL>> reason to needless deviate from NetBSD here. One could make an
AL>> argument for lots of different files, but at the end of the day does
AL>> it really matter enough to justify having it be different than NetBSD?
AL
AL>> Here's my proposed diff, inline, for your consideration:
AL
AL
AL
AL>> NOTE: That /* !_KERNEL */ should have the '!' removed, but I didn't
AL>> want to confuse things by doing that too.
AL
AL>> Comments?
AL
AL>> Warner
AL>> _______________________________________________
AL>Who not create abstract framework for work with bitmask more then 64bits
AL>size?
AL>similar this:
AL
AL>#define_bitmask(name,size) char name[(size/+1];
AL>#define set_bit(bimask,no) { bitmask[(no/] |= 1<<(no%; }
AL>#define clr_bit(bitmask,no) { bitmask[(no/] &= ~(1<<(no%); }
AL>static inline isset_bit(char *bitmask, no) {
AL> return bitmask[(no/] & 1<<(no%;
You mean bitstring(3)?
Thanks for point this. |
--
Alex Lyashkov <shadow@psoft.net>
Positive Software
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
M. Warner Losh
*nix forums Guru
Joined: 22 Mar 2002
Posts: 365
|
| Posted: Wed Jun 28, 2006 3:55 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
In message: <1151490061.3525.9.camel@berloga.shadowland>
Alex Lyashkov <shadow@psoft.net> writes:
: ÷ ÷ÔÒ, 27.06.2006, × 22:58, M. Warner Losh ÐÉÛÅÔ:
: > NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
: > is defined). I'd like to do something similar in FreeBSD. I see no
: > reason to needless deviate from NetBSD here. One could make an
: > argument for lots of different files, but at the end of the day does
: > it really matter enough to justify having it be different than NetBSD?
: >
: > Here's my proposed diff, inline, for your consideration:
: >
:
: >
: > NOTE: That /* !_KERNEL */ should have the '!' removed, but I didn't
: > want to confuse things by doing that too.
: >
: > Comments?
: >
: > Warner
: > _______________________________________________
: Who not create abstract framework for work with bitmask more then 64bits
: size?
: similar this:
:
: #define_bitmask(name,size) char name[(size/+1];
: #define set_bit(bimask,no) { bitmask[(no/] |= 1<<(no%; }
: #define clr_bit(bitmask,no) { bitmask[(no/] &= ~(1<<(no%); }
: static inline isset_bit(char *bitmask, no) {
: return bitmask[(no/] & 1<<(no%;
: }
This isn't about 'frameworks' but rather a simple set of macros to aid
in the porting of code from other systems.
Warner
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Hans Petter Selasky
*nix forums beginner
Joined: 15 Mar 2006
Posts: 5
|
| Posted: Wed Jun 28, 2006 4:24 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
On Tuesday 27 June 2006 21:58, M. Warner Losh wrote:
| Quote: | NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
is defined). I'd like to do something similar in FreeBSD. I see no
reason to needless deviate from NetBSD here. One could make an
argument for lots of different files, but at the end of the day does
it really matter enough to justify having it be different than NetBSD?
Here's my proposed diff, inline, for your consideration:
Index: types.h
===================================================================
RCS file: /home/ncvs/src/sys/sys/types.h,v
retrieving revision 1.95
diff -u -r1.95 types.h
--- types.h 26 Nov 2005 12:42:35 -0000 1.95
+++ types.h 27 Jun 2006 19:57:23 -0000
@@ -294,6 +294,11 @@
#define offsetof(type, field) __offsetof(type, field)
+/* Macros to clear/set/test flags. */
+#define SET(t, f) (t) |= (f)
+#define CLR(t, f) (t) &= ~(f)
+#define ISSET(t, f) ((t) & (f))
+
#endif /* !_KERNEL */
|
I am currently expanding those macros in all the USB drivers I am rewriting.
--HPS
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Yar Tikhiy
*nix forums beginner
Joined: 08 Apr 2003
Posts: 36
|
| Posted: Wed Jun 28, 2006 5:47 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
On Wed, Jun 28, 2006 at 08:08:24PM +1000, Andrew Reilly wrote:
| Quote: | On Wed, Jun 28, 2006 at 09:53:46AM +0000, Poul-Henning Kamp wrote:
In message <20060628094221.GA50978@comp.chem.msu.su>, Yar Tikhiy writes:
On Tue, Jun 27, 2006 at 01:58:17PM -0600, M. Warner Losh wrote:
NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
is defined).
As one of the people who have worked with the original /bin/sh source
code, I have a slight alergic reaction to attempts to paste over
the implementation language with macros like these.
Setting a bit in 'C' is spelled
variable |= bit;
not
SET(variable, bit);
To my eye, if you're going to use "bit" to describe which bit is
being operated on, then you should *really* be doing:
variable |= (1 << bit)
and, obviously, SET(variable, bit) should do that, rather than
what has been proposed.
|
That would require converting our device .h files from defining bit
masks to defining bit numbers. I don't mind you doing that as long
as SET is expanded to:
((variable) |= (1 << (bit)))
-- note the bunch of roughly balanced parentheses ;-)
--
Yar
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Andrew R. Reiter
*nix forums beginner
Joined: 01 Apr 2002
Posts: 11
|
| Posted: Wed Jun 28, 2006 7:04 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
I apologize for top posting, but I lost the email that I think my
point/question pertains to.
Part of this seems to be for compatibility / merging from drivers of other
OSes, no? If I am wrong, ignore me  . If this is the case, would it be
better to create some common other area for things of this nature so that
it suffices to allow builds, but does not infect other areas of our own
code base?
Could be a poor idea, but just throwing it out there for the fsck of it.
Cheers,
Andrew
On Wed, 28 Jun 2006, Yar Tikhiy wrote:
:On Wed, Jun 28, 2006 at 08:08:24PM +1000, Andrew Reilly wrote:
:> On Wed, Jun 28, 2006 at 09:53:46AM +0000, Poul-Henning Kamp wrote:
:> > In message <20060628094221.GA50978@comp.chem.msu.su>, Yar Tikhiy writes:
:> > >On Tue, Jun 27, 2006 at 01:58:17PM -0600, M. Warner Losh wrote:
:> >
:> > >> NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
:> > >> is defined).
:> >
:> > As one of the people who have worked with the original /bin/sh source
:> > code, I have a slight alergic reaction to attempts to paste over
:> > the implementation language with macros like these.
:> >
:> > Setting a bit in 'C' is spelled
:> > variable |= bit;
:> > not
:> > SET(variable, bit);
:>
:> To my eye, if you're going to use "bit" to describe which bit is
:> being operated on, then you should *really* be doing:
:> variable |= (1 << bit)
:> and, obviously, SET(variable, bit) should do that, rather than
:> what has been proposed.
:
:That would require converting our device .h files from defining bit
:masks to defining bit numbers. I don't mind you doing that as long
:as SET is expanded to:
:
: ((variable) |= (1 << (bit)))
:
:-- note the bunch of roughly balanced parentheses 
:
:--
:Yar
:_______________________________________________
:freebsd-arch@freebsd.org mailing list
:http://lists.freebsd.org/mailman/listinfo/freebsd-arch
:To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"
:
:
--
arr@watson.org
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Julian Elischer
*nix forums Guru Wannabe
Joined: 20 Mar 2002
Posts: 279
|
| Posted: Wed Jun 28, 2006 7:22 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
Andrew R. Reiter wrote:
| Quote: | I apologize for top posting, but I lost the email that I think my
point/question pertains to.
Part of this seems to be for compatibility / merging from drivers of other
OSes, no? If I am wrong, ignore me . If this is the case, would it be
better to create some common other area for things of this nature so that
it suffices to allow builds, but does not infect other areas of our own
code base?
|
how about just making a /sys/sys/netbsd_compat.h
and /sys/sys/openbsd_compat.h
put this sort of thing in there..
| Quote: | Could be a poor idea, but just throwing it out there for the fsck of it.
Cheers,
Andrew
On Wed, 28 Jun 2006, Yar Tikhiy wrote:
:On Wed, Jun 28, 2006 at 08:08:24PM +1000, Andrew Reilly wrote:
:> On Wed, Jun 28, 2006 at 09:53:46AM +0000, Poul-Henning Kamp wrote:
:> > In message <20060628094221.GA50978@comp.chem.msu.su>, Yar Tikhiy writes:
:> > >On Tue, Jun 27, 2006 at 01:58:17PM -0600, M. Warner Losh wrote:
:
:> > >> NetBSD recently added SET, CLR, ISSET to sys/types.h (only if _KERNEL
:> > >> is defined).
:
:> > As one of the people who have worked with the original /bin/sh source
:> > code, I have a slight alergic reaction to attempts to paste over
:> > the implementation language with macros like these.
:
:> > Setting a bit in 'C' is spelled
:> > variable |= bit;
:> > not
:> > SET(variable, bit);
:
:> To my eye, if you're going to use "bit" to describe which bit is
:> being operated on, then you should *really* be doing:
:> variable |= (1 << bit)
:> and, obviously, SET(variable, bit) should do that, rather than
:> what has been proposed.
:
:That would require converting our device .h files from defining bit
:masks to defining bit numbers. I don't mind you doing that as long
:as SET is expanded to:
:
: ((variable) |= (1 << (bit)))
:
:-- note the bunch of roughly balanced parentheses
:
:--
:Yar
:_______________________________________________
:freebsd-arch@freebsd.org mailing list
:http://lists.freebsd.org/mailman/listinfo/freebsd-arch
:To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"
:
:
--
arr@watson.org
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"
_______________________________________________ |
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Poul-Henning Kamp
*nix forums Guru
Joined: 21 Mar 2002
Posts: 436
|
| Posted: Wed Jun 28, 2006 8:29 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
In message <20060628150227.R75801@fledge.watson.org>, "Andrew R. Reiter" writes
:
| Quote: |
I apologize for top posting, but I lost the email that I think my
point/question pertains to.
Part of this seems to be for compatibility / merging from drivers of other
OSes, no? If I am wrong, ignore me . If this is the case, would it be
better to create some common other area for things of this nature so that
it suffices to allow builds, but does not infect other areas of our own
code base?
|
That's what I proposed too: #include <sys/netbsd_compat.h>
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
M. Warner Losh
*nix forums Guru
Joined: 22 Mar 2002
Posts: 365
|
| Posted: Wed Jul 05, 2006 3:15 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
In message: <28872.1151526546@critter.freebsd.dk>
"Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
: In message <20060628150227.R75801@fledge.watson.org>, "Andrew R. Reiter" writes
: :
: >
: >I apologize for top posting, but I lost the email that I think my
: >point/question pertains to.
: >
: >Part of this seems to be for compatibility / merging from drivers of other
: >OSes, no? If I am wrong, ignore me . If this is the case, would it be
: >better to create some common other area for things of this nature so that
: >it suffices to allow builds, but does not infect other areas of our own
: >code base?
:
: That's what I proposed too: #include <sys/netbsd_compat.h>
This is even lamer. It makes no sense to invent a stupid place for a
compatibility define. Might as well put the definition of NULL in
limits.h.
I'm killing this idea because people hate it.
Warner
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Andrew R. Reiter
*nix forums beginner
Joined: 01 Apr 2002
Posts: 11
|
| Posted: Wed Jul 05, 2006 3:43 pm Post subject:
Re: SET, CLR, ISSET in types.h for _KERNEL builds
|
|
|
On Wed, 5 Jul 2006, M. Warner Losh wrote:
:In message: <28872.1151526546@critter.freebsd.dk>
: "Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
:: In message <20060628150227.R75801@fledge.watson.org>, "Andrew R. Reiter" writes
:: :
:: >
:: >I apologize for top posting, but I lost the email that I think my
:: >point/question pertains to.
:: >
:: >Part of this seems to be for compatibility / merging from drivers of other
:: >OSes, no? If I am wrong, ignore me . If this is the case, would it be
:: >better to create some common other area for things of this nature so that
:: >it suffices to allow builds, but does not infect other areas of our own
:: >code base?
::
:: That's what I proposed too: #include <sys/netbsd_compat.h>
:
:This is even lamer. It makes no sense to invent a stupid place for a
:compatibility define. Might as well put the definition of NULL in
:limits.h.
:
:I'm killing this idea because people hate it.
Please explain which "idea" you're killing ... because your post-July 4th
attitude does not make it clear.
THANKS!
:
:Warner
:
:
--
arr@watson.org
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" |
|
| Back to top |
|
|
Google
|
|
| Back to top |
|
|
|
|
The time now is Fri Nov 21, 2008 3:42 am | All times are GMT
|
|
Bad Credit Debt Consolidation | Problem Mortgage | Repair Bad Credit | Loan | Mortgages
|
|
Copyright © 2004-2005 DeniX Solutions SRL
|
|
|
|
Other DeniX Solutions sites:
Unix/Linux blog |
electronics forum |
medicine forum |
science forum |
|
|
Privacy Policy
|
Powered by phpBB © 2001, 2005 phpBB Group
|
|
FAQ
Search
Memberlist
Usergroups
Register
Profile
Log in to check your private messages
Log in
Forum index
»
*nix
»
BSD
»
FreeBSD
»
mail-lists
»
Architecture
